search

abhi-r3v0 / Adhrit

Android Security Suite for in-depth reconnaissance and static bytecode analysis based on Ghera benchmarks.
https://www.hawkspawn.com/Adhrit
GNU General Public License v3.0
535 stars 129 forks source link

PEP8 violations, other conventions #2

Closed tonythomas01 closed 6 years ago

tonythomas01 commented 6 years ago

Something to note: 

➜  Adhrit git:(master) pep8 . 
./Installer.py:4:21: E203 whitespace before ':'
./Installer.py:6:23: E203 whitespace before ':'
./Installer.py:9:12: E211 whitespace before '('
./Installer.py:9:19: E203 whitespace before ':'
./Installer.py:11:12: E203 whitespace before ':'
./Installer.py:14:30: E203 whitespace before ':'
./Installer.py:18:12: E203 whitespace before ':'
./Installer.py:19:80: E501 line too long (85 > 79 characters)
./Installer.py:24:30: E203 whitespace before ':'
./Installer.py:28:12: E203 whitespace before ':'
./Installer.py:31:30: E203 whitespace before ':'
./Installer.py:35:11: E203 whitespace before ':'
./Installer.py:39:1: E305 expected 2 blank lines after class or function definition, found 1
./Installer.py:39:26: E203 whitespace before ':'
./adhrit.py:3:1: E265 block comment should start with '# '
./adhrit.py:4:1: E265 block comment should start with '# '
./adhrit.py:26:13: E203 whitespace before ':'
./adhrit.py:28:23: E203 whitespace before ':'
./adhrit.py:33:5: E303 too many blank lines (2)
./adhrit.py:33:22: E203 whitespace before ':'
./adhrit.py:36:1: E101 indentation contains mixed spaces and tabs
./adhrit.py:36:1: W191 indentation contains tabs
./adhrit.py:39:1: E101 indentation contains mixed spaces and tabs
./adhrit.py:39:5: E265 block comment should start with '# '
./adhrit.py:39:5: E303 too many blank lines (2)
./adhrit.py:40:34: E203 whitespace before ':'
./adhrit.py:43:5: E265 block comment should start with '# '
./adhrit.py:47:5: E265 block comment should start with '# '
./adhrit.py:47:80: E501 line too long (103 > 79 characters)
./adhrit.py:51:5: E265 block comment should start with '# '
./adhrit.py:55:5: E265 block comment should start with '# '
./adhrit.py:59:5: E265 block comment should start with '# '
./adhrit.py:63:5: E265 block comment should start with '# '
./adhrit.py:69:1: E265 block comment should start with '# '
./adhrit.py:69:1: E303 too many blank lines (3)
./adhrit.py:70:1: E302 expected 2 blank lines, found 3
./adhrit.py:70:11: E203 whitespace before ':'
./adhrit.py:73:49: E251 unexpected spaces around keyword / parameter equals
./adhrit.py:73:51: E251 unexpected spaces around keyword / parameter equals
./adhrit.py:89:8: E101 indentation contains mixed spaces and tabs
./adhrit.py:89:8: W191 indentation contains tabs
./adhrit.py:94:5: E303 too many blank lines (2)
./adhrit.py:99:5: E303 too many blank lines (2)
./adhrit.py:104:5: E303 too many blank lines (2)
./adhrit.py:112:16: E203 whitespace before ':'
./adhrit.py:116:5: E303 too many blank lines (2)
./adhrit.py:116:16: E203 whitespace before ':'
./adhrit.py:120:5: E303 too many blank lines (2)
./adhrit.py:120:16: E203 whitespace before ':'
./adhrit.py:124:16: E203 whitespace before ':'
./adhrit.py:129:26: E203 whitespace before ':'
./Recons/Dynamic.py:4:1: E302 expected 2 blank lines, found 1
./Recons/Dynamic.py:4:21: E203 whitespace before ':'
./Recons/Dynamic.py:12:18: E203 whitespace before ':'
./Recons/Dynamic.py:13:80: E501 line too long (95 > 79 characters)
./Recons/Dynamic.py:15:9: E203 whitespace before ':'
./Recons/Dynamic.py:20:5: E303 too many blank lines (2)
./Recons/Dynamic.py:20:18: E203 whitespace before ':'
./Recons/Dynamic.py:23:29: E203 whitespace before ':'
./Recons/Dynamic.py:26:13: E203 whitespace before ':'
./Recons/Dynamic.py:30:5: E303 too many blank lines (2)
./Recons/Dynamic.py:30:22: E203 whitespace before ':'
./Recons/Dynamic.py:31:54: E225 missing whitespace around operator
./Recons/Dynamic.py:31:62: E225 missing whitespace around operator
./Recons/Dynamic.py:31:80: E501 line too long (102 > 79 characters)
./Recons/Dynamic.py:32:17: E225 missing whitespace around operator
./Recons/Dynamic.py:36:9: E303 too many blank lines (2)
./Recons/Dynamic.py:37:12: E225 missing whitespace around operator
./Recons/Dynamic.py:38:12: E225 missing whitespace around operator
./Recons/Dynamic.py:39:50: E225 missing whitespace around operator
./Recons/Dynamic.py:39:80: E501 line too long (112 > 79 characters)
./Recons/Dynamic.py:40:14: E225 missing whitespace around operator
./Recons/Dynamic.py:41:12: E225 missing whitespace around operator
./Recons/Dynamic.py:42:80: E501 line too long (120 > 79 characters)
./Recons/Dynamic.py:46:14: E225 missing whitespace around operator
./Recons/Dynamic.py:48:32: E203 whitespace before ':'
./Recons/Dynamic.py:51:45: E225 missing whitespace around operator
./Recons/Dynamic.py:51:53: E225 missing whitespace around operator
./Recons/NativeRecon.py:8:26: E203 whitespace before ':'
./Recons/NativeRecon.py:11:64: E203 whitespace before ':'
./Recons/NativeRecon.py:14:54: E203 whitespace before ':'
./Recons/NativeRecon.py:22:23: E203 whitespace before ':'
./Recons/NativeRecon.py:23:34: E203 whitespace before ':'
./Recons/NativeRecon.py:24:73: E225 missing whitespace around operator
./Recons/NativeRecon.py:24:75: E225 missing whitespace around operator
./Recons/NativeRecon.py:24:76: E222 multiple spaces after operator
./Recons/NativeRecon.py:24:80: E501 line too long (91 > 79 characters)
./Recons/NativeRecon.py:27:59: E225 missing whitespace around operator
./Recons/NativeRecon.py:32:5: E303 too many blank lines (2)
./Recons/NativeRecon.py:32:9: E203 whitespace before ':'
./Recons/NativeRecon.py:33:80: E501 line too long (87 > 79 characters)
./Recons/SmaliExtract.py:4:22: E203 whitespace before ':'
./Recons/SmaliExtract.py:5:80: E501 line too long (80 > 79 characters)
./Recons/SmaliExtract.py:13:1: E302 expected 2 blank lines, found 1
./Recons/VirusTotal.py:6:23: E203 whitespace before ':'
./Recons/VirusTotal.py:9:80: E501 line too long (80 > 79 characters)
./Recons/VirusTotal.py:12:35: E203 whitespace before ':'
./Recons/VirusTotal.py:13:53: E203 whitespace before ':'
./Recons/VirusTotal.py:17:27: E203 whitespace before ':'
./Recons/VirusTotal.py:17:80: E501 line too long (120 > 79 characters)
./Recons/VirusTotal.py:17:119: E202 whitespace before '}'
./Recons/VirusTotal.py:24:5: E128 continuation line under-indented for visual indent
./Recons/apkExtract.py:10:1: E265 block comment should start with '# '
./Recons/apkExtract.py:10:1: E303 too many blank lines (3)
./Recons/apkExtract.py:11:1: E302 expected 2 blank lines, found 3
./Recons/apkExtract.py:11:22: E203 whitespace before ':'
./Recons/apkExtract.py:15:80: E501 line too long (80 > 79 characters)
./Recons/apkExtract.py:19:21: E225 missing whitespace around operator
./Recons/apkExtract.py:25:5: E303 too many blank lines (4)
./Recons/apkExtract.py:25:80: E501 line too long (80 > 79 characters)
./Recons/apkExtract.py:28:80: E225 missing whitespace around operator
./Recons/apkExtract.py:28:80: E501 line too long (126 > 79 characters)
./Recons/apkExtract.py:30:80: E501 line too long (91 > 79 characters)
./Recons/apkExtract.py:32:80: E501 line too long (80 > 79 characters)
./Recons/apkExtract.py:44:5: E303 too many blank lines (4)
./Recons/apkExtract.py:44:80: E501 line too long (81 > 79 characters)
./Recons/apkExtract.py:46:39: E203 whitespace before ':'
./Recons/apkExtract.py:47:21: E225 missing whitespace around operator
./Recons/apkExtract.py:48:34: E203 whitespace before ':'
./Recons/apkExtract.py:55:5: E303 too many blank lines (3)
./Recons/apkExtract.py:55:80: E501 line too long (80 > 79 characters)
./Recons/apkExtract.py:57:80: E501 line too long (113 > 79 characters)
./Recons/apkExtract.py:63:5: E303 too many blank lines (3)
./Recons/apkExtract.py:63:80: E501 line too long (80 > 79 characters)
./Recons/apkExtract.py:66:38: E203 whitespace before ':'
./Recons/apkExtract.py:74:5: E303 too many blank lines (4)
./Recons/apkExtract.py:74:80: E501 line too long (80 > 79 characters)
./Recons/apkExtract.py:83:5: E303 too many blank lines (2)
./Recons/apkExtract.py:83:80: E501 line too long (80 > 79 characters)
./Recons/apkExtract.py:88:36: E203 whitespace before ':'
./Recons/apkExtract.py:94:80: E501 line too long (80 > 79 characters)
./Recons/apkRecon.py:9:1: E265 block comment should start with '# '
./Recons/apkRecon.py:9:1: E303 too many blank lines (3)
./Recons/apkRecon.py:10:1: E302 expected 2 blank lines, found 3
./Recons/apkRecon.py:10:12: E201 whitespace after '('
./Recons/apkRecon.py:10:21: E202 whitespace before ')'
./Recons/apkRecon.py:10:23: E203 whitespace before ':'
./Recons/apkRecon.py:16:5: E303 too many blank lines (2)
./Recons/apkRecon.py:16:80: E501 line too long (80 > 79 characters)
./Recons/apkRecon.py:18:40: E225 missing whitespace around operator
./Recons/apkRecon.py:22:80: E501 line too long (80 > 79 characters)
./Recons/apkRecon.py:24:80: E501 line too long (80 > 79 characters)
./Recons/apkRecon.py:28:80: E501 line too long (80 > 79 characters)
./Recons/apkRecon.py:30:80: E501 line too long (82 > 79 characters)
./Recons/apkRecon.py:32:41: E203 whitespace before ':'
./Recons/apkRecon.py:37:80: E501 line too long (80 > 79 characters)

also some naming conventions in https://github.com/abhi-r3v0/Adhrit/tree/master/Recons, and this looks great.

Function names should be lowercase, with words separated by underscores as necessary to improve readability. similar for file names in Recons

tonythomas01 commented 6 years ago

For a standard, add travis-ci pipeline which would do a pep8 . on all files before it gets merged. https://travis-ci.org/