abhi11 / tanglu-dak

GNU General Public License v2.0
0 stars 2 forks source link

Some more style and DEP-11 bugfixes #2

Closed ximion closed 10 years ago

ximion commented 10 years ago

Hi! These patches should adjust your generator to follow the DEP-11 spec, and also add some best-practice adjustments. (e.g. don't paper over issues with "make_num", instead enforce consistency and check if the thing you want to add is really a number) There were also still some issues in your setters/getters and verious other issues, the biggest one was that the "Packages" field was missing the whole time from the generated data - please add it as soon as possible! Also, don't overuse try...except - use it as rarely as possible. Cheers, Matthias

P.S: That code is entirely untested, I hacked it together this night - take it as example for the other code you have there.