abhi11 / tanglu-dak

GNU General Public License v2.0
0 stars 2 forks source link

Generated DEP-11 files do not pass validator tests #9

Closed ximion closed 9 years ago

ximion commented 9 years ago

There are various issues found:

[virtaal.desktop][Summary]: String is quoted: ''n Vertaalprogram om 'n vertaler te help om lêers na ander tale te vertaal' @ af
[advancedcaching.desktop][Summary]: AppStream locale names should not specify encoding (ends with .UTF-8)
[zim.desktop][Summary]: String is quoted: '"ウィキ形式"の文書を作成します' @ ja
[zim.desktop][Summary]: String is quoted: '"Viki stiilis" teksti kirjutamine' @ et
[pybridge.desktop]: required key not provided @ data['Summary']['C']
[wxglade.desktop][Summary]: AppStream locale names should not specify encoding (ends with .UTF-8)
[wxglade.desktop][Summary]: AppStream locale names should not specify encoding (ends with .UTF-8)
[monajat.desktop]: required key not provided @ data['Name']
[eric5.desktop]: required key not provided @ data['Name']
[ghex.desktop][Name]: String is quoted: '""GHex' @ hr
[gxine.desktop]: required key not provided @ data['Name']
Validation failed!

It would be good if the code did a fast validation, to ensure the generated data is at least somewhat sane (missing "Name" or missing "Packages" key are a no-go).

ximion commented 9 years ago

There is more, with a larger repo analysis. Using the Tanglu Debian derivative, with is equal in package-size to Debian:

Tanglu 2 (Alpha) Bartholomea annluata, main component, arch:amd64:

[ghex.desktop][Name]: String is quoted: '""GHex' @ hr
[texworks.desktop][Summary]: String is quoted: ''n Eenvoudige omgewing vir die redigering, setwerk, en besigtiging van TeX dokumente' @ af
[gnome-maps.desktop][Summary]: String is quoted: ''n Eenvoudige padkaart-toepassing' @ af
FATAL: Found two components with the same ID: flsudoku.desktop.
FATAL: Found two components with the same ID: flcheckers.desktop.
FATAL: Found two components with the same ID: flblocks.desktop.
[khangman.desktop][Description]: Found cruft locale: x-test
[rocs.desktop][Description]: Found cruft locale: x-test
[cantor.desktop][Description]: Found cruft locale: x-test
[xine.desktop]: required key not provided @ data['Name']
[kolourpaint.desktop][Description]: Found cruft locale: x-test
[kturtle.desktop][Description]: Found cruft locale: x-test
[blinken.desktop][Description]: Found cruft locale: x-test
[kanagram.desktop][Description]: Found cruft locale: x-test
[libreoffice-impress.desktop]: required key not provided @ data['Name']
[libreoffice-math.desktop]: required key not provided @ data['Name']
[ktnef.desktop][Summary]: String is quoted: ''n Leeser en data onttrekker vir TNEF lêers' @ af
Validation failed!

Tanglu 2 (Alpha) Bartholomea annluata, main component, arch:all:

[virtaal.desktop][Summary]: String is quoted: ''n Vertaalprogram om 'n vertaler te help om lêers na ander tale te vertaal' @ af
[advancedcaching.desktop][Summary]: AppStream locale names should not specify encoding (ends with .UTF-8)
[zim.desktop][Summary]: String is quoted: '"Viki stiilis" teksti kirjutamine' @ et
[zim.desktop][Summary]: String is quoted: '"ウィキ形式"の文書を作成します' @ ja
[pybridge.desktop]: required key not provided @ data['Summary']['C']
[wxglade.desktop][Summary]: AppStream locale names should not specify encoding (ends with .UTF-8)
[wxglade.desktop][Summary]: AppStream locale names should not specify encoding (ends with .UTF-8)
FATAL: Found two components with the same ID: debian-installer-launcher.desktop.
[monajat.desktop]: required key not provided @ data['Name']
[eric5.desktop]: required key not provided @ data['Name']
[evolution.desktop]: required key not provided @ data['Name']
[fotoxx.desktop]: required key not provided @ data['Name']
[scilab.desktop]: required key not provided @ data['Name']
FATAL: Found two components with the same ID: scilab.desktop.
[freeciv-modpack.desktop]: required key not provided @ data['Name']
[freeciv-server.desktop]: required key not provided @ data['Name']
[freeciv.desktop]: required key not provided @ data['Name']
[freeciv-gtk3.desktop]: required key not provided @ data['Name']
[freeciv-sdl.desktop]: required key not provided @ data['Name']
[libreoffice-xsltfilter.desktop]: required key not provided @ data['Name']
[libreoffice-startcenter.desktop]: required key not provided @ data['Name']
[gnome-power-statistics.desktop]: required key not provided @ data['Name']
[cangjie.xml]: required key not provided @ data['Name']
[quick.xml]: required key not provided @ data['Name']
Validation failed!
abhi11 commented 9 years ago

I just checked. The "required key not provided @ data['Name']" error is occurring because these .desktop files are invalid they are actually ) bytes files. I should ignore this components which I wasn't doing.

abhi11 commented 9 years ago

http://archive.tanglu.org/tanglu/pool/main/m/monajat/ check the deb files , the desktop files are 0 bytes

abhi11 commented 9 years ago

I have made a commit which should finish the data[Name] no found issue.

ximion commented 9 years ago

The issues mentioned here are fixed, but there are a few other things which make the files fail validator tests. Especially ID-uniqueness is a problem... (I'll file a new issue for that)