abhi16180 / photon

Photon is a cross-platform file-transfer application built using flutter. It uses http to transfer files between devices. You can transfer files between any devices that run Photon.
https://photondev.netlify.app
GNU General Public License v3.0
465 stars 41 forks source link

Add support for all private network IP ranges #90

Open koca2000 opened 1 year ago

koca2000 commented 1 year ago

The application currently only supports IP range starting with 192.168.. However, there are also 10.0.0.0 - 10.255.255.255 and 172.16.0.0 - 172.31.255.255 (Wikipedia)

abhi16180 commented 1 year ago

The application currently only supports IP range starting with 192.168.. However, there are also 10.0.0.0 - 10.255.255.255 and 172.16.0.0 - 172.31.255.255 (Wikipedia)

It was intentionally set to 192.168.xxx.xxx because the senders' ip should bind to the wifi network that laptop or mobile is connected. You can find multiple network interfaces with different ip inside same device. Finding IP other than class C is rare case. One of such situations is when you have virtual machine installed on top of your host machine. In that case you could get class B or class A address also. I thought of allowing users to select network interface before sharing. But it won't be user friendly for general public. But in upcoming version will consider adding this as an option to advanced users.

koca2000 commented 1 year ago

That would be nice because it is not a general rule that all wifi networks are 192.168.xxx.xxx. My wifi use 10.10.10.xxx network.

abhi16180 commented 1 year ago

That would be nice because it is not a general rule that all wifi networks are 192.168.xxx.xxx. My wifi use 10.10.10.xxx network.

Okay, will consider adding support to other private IPs as well.

SirTerrific commented 4 months ago

That would be nice because it is not a general rule that all wifi networks are 192.168.xxx.xxx. My wifi use 10.10.10.xxx network.

Okay, will consider adding support to other private IPs as well.

It will be great. I was looking for a software like yours but when I saw that I was not able to select my interface, I'm crying TT___TT

abhi16180 commented 4 months ago

That would be nice because it is not a general rule that all wifi networks are 192.168.xxx.xxx. My wifi use 10.10.10.xxx network.

Okay, will consider adding support to other private IPs as well.

It will be great. I was looking for a software like yours but when I saw that I was not able to select my interface, I'm crying TT___TT

@SirTerrific More flexibility will be added to ip range selection in the next update.

SirTerrific commented 4 months ago

That would be nice because it is not a general rule that all wifi networks are 192.168.xxx.xxx. My wifi use 10.10.10.xxx network.

Okay, will consider adding support to other private IPs as well.

It will be great. I was looking for a software like yours but when I saw that I was not able to select my interface, I'm crying TT___TT

@SirTerrific More flexibility will be added to ip range selection in the next update.

That’s really nice of you!