gitguardian[bot]
commented
3 months ago ⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [8229085](https://dashboard.gitguardian.com/workspace/119687/incidents/8229085) | Triggered | SMTP credentials | c071ae9c6ba1d6ba35654b35f5eb5edaad2e4928 | src/main/resources/application.properties.sample | [View secret](https://github.com/abhi9720/BankingPortal-API/commit/c071ae9c6ba1d6ba35654b35f5eb5edaad2e4928#diff-8ef29f4f67e160b121b6c2aa28b543b875cf9bc907287196d606d43a5a27a764R24) | | [8229085](https://dashboard.gitguardian.com/workspace/119687/incidents/8229085) | Triggered | SMTP credentials | b2151e88ca88b89aeec7d3e6c4b6cfe5a8bb3df4 | src/main/resources/application.properties.sample | [View secret](https://github.com/abhi9720/BankingPortal-API/commit/b2151e88ca88b89aeec7d3e6c4b6cfe5a8bb3df4#diff-8ef29f4f67e160b121b6c2aa28b543b875cf9bc907287196d606d43a5a27a764R24) | | [9399491](https://dashboard.gitguardian.com/workspace/119687/incidents/9399491) | Triggered | Username Password | 85f5ee3fdb502882bc61d3761846024412400446 | target/classes/application.properties | [View secret](https://github.com/abhi9720/BankingPortal-API/commit/85f5ee3fdb502882bc61d3761846024412400446#diff-eaad3827860d64bb79e22ec9e6eca1f5c9a67317a4ab1b62f68e23b997f784b7R4) | | [9399492](https://dashboard.gitguardian.com/workspace/119687/incidents/9399492) | Triggered | SMTP credentials | 85f5ee3fdb502882bc61d3761846024412400446 | target/classes/application.properties | [View secret](https://github.com/abhi9720/BankingPortal-API/commit/85f5ee3fdb502882bc61d3761846024412400446#diff-eaad3827860d64bb79e22ec9e6eca1f5c9a67317a4ab1b62f68e23b997f784b7R21) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/specifics/smtp_assignment#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Hello there!
I'm excited to submit this pull request which brings significant improvements to your BankingPortal-API. Here's a quick rundown of the changes:
Refactoring: The codebase has been thoroughly refactored for better readability and maintainability. This includes simplifying complex methods, and renaming variables for clarity.
Integration Tests: A suite of integration tests has been added to ensure the robustness of our API. These tests cover a wide range of scenarios and are designed to catch any potential issues before they make it to production.
Logging: SLF4J has been utilized to implement comprehensive logging throughout the application. This will provide us with better and quicker debugging capabilities.
Looking forward to your feedback and suggestions!