abhiTronix / deffcode

A cross-platform High-performance FFmpeg based Real-time Video Frames Decoder in Pure Python 🎞️⚡
https://abhitronix.github.io/deffcode
Apache License 2.0
182 stars 4 forks source link

🐛 FFdecoder: Refactored Process Termination and various important updates. #53

Closed abhiTronix closed 3 months ago

abhiTronix commented 3 months ago

Brief Description

This pull request includes several significant updates and improvements:

Title: End Support for Python 3.7, Improve Documentation, and Refactor Process Termination

  1. End of Support for Python 3.7 (Fixes #48):

    • Increased the minimum required Python version to 3.8.
    • Removed deprecated Python 3.7 references from the metadata.
  2. Documentation Enhancements (Fixes #44):

    • Added detailed instructions and context for Input and Output Seeking methods.
    • Introduced sections on Input Seeking and Output Seeking, highlighting their pros, cons, and providing usage examples.
    • Included a warning about the accuracy issues when using output seeking with filters.
    • Improved overall document structure and readability.
  3. FFdecoder Process Termination Refactor (Fixes #41):

    • Refactored the process termination method to use terminate() instead of kill() for a more graceful shutdown.
    • Ensured that the terminate() method sends the appropriate signal (SIGTERM on Unix, TerminateProcess() on Windows).
    • Simplified conditional checks using short-circuiting.

Requirements / Checklist

Related Issue

48

44

41

Context

These changes collectively aim to modernize the codebase by discontinuing support for outdated Python versions, enhance the documentation for better user understanding, and ensure more reliable and graceful process termination methods.

Types of changes

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.83%. Comparing base (d448e1d) to head (87e6643).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #53 +/- ## ========================================== - Coverage 95.84% 95.83% -0.01% ========================================== Files 6 6 Lines 794 793 -1 ========================================== - Hits 761 760 -1 Misses 33 33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.