search

abhiaiyer91 / apollo-storybook-decorator

Wrap your storybook environment with Apollo Client, provide mocks for isolated UI testing with GraphQL
332 stars 34 forks source link

Angular package should be distributed as compiled JS, not TS #132

Open ghost opened 4 years ago

ghost commented 4 years ago

Hi! I really appreciate that you've made an Angular version, but would it be possible to update your packaging process to run tsc --build on the Angular package before publishing it? I think it's fairly common to not recompile all dependencies in a Typescript workflow, so the decorator never actually gets compiled (at least with our workflow).

I'm not super familiar with Lerna, but I would guess it could simply be a matter of running a script from the inner package.json before completing the build.

Might also want to add main and types keys to the inner package.json as well, to help with resolutions.

If you'd prefer, I could try doing a PR for this, just let me know.

alexisponcet commented 4 years ago

I agree, that could be a really nice idea.

alanhobbart commented 1 year ago

Hi, is there any documentation on how to use the Angular version? I can’t find any