abhiamishra / ggshakeR

An analysis and visualization R package that works with publicly available soccer data
https://abhiamishra.github.io/ggshakeR/
MIT License
113 stars 14 forks source link

[Bug]: Pkgdown Website Dependencies Failing #104

Closed abhiamishra closed 2 years ago

abhiamishra commented 2 years ago

What happened?


ggshakeR version: 0.2.0.99990 R version: 4.0

Brief description of the problem

" * pkgdown: dependencies must be TRUE, FALSE, NA or a list of dependency types "

rithwikrajendran commented 2 years ago

Is this due to the update of setup-r-dependencies@v1 to setup-r-dependencies@v2 in the pkgdown.yaml in workflows? If yes, updating line extra-packages: pkgdown to extra-packages: any::pkgdown in the same file for pkgdown should do the trick.

References:

  1. Issue 1
  2. Issue 2
abhiamishra commented 2 years ago

Yeah this is the same solution Harsh showed me so its probably just this

harshkrishna17 commented 2 years ago

Committed #105 but build still failing

Ryo-N7 commented 2 years ago

Committed #105 but build still failing

did you try building the website locally with pkgdown::build_site() first?

below is the error from the latest:

 -- Building function reference -------------------------------------------------
Writing 'reference/index.html'
Error in library(pkg$package, character.only = TRUE) : 
  there is no package called ‘ggshakeR’
Calls: <Anonymous> ... build_site_local -> build_reference -> examples_env -> library
11 Removing worktree 11111111111111111111111111111111111111111111111111111111111
Running git worktree remove /tmp/Rtmp6t0ctX/file29932cba8b5b
Execution halted
Error: Process completed with exit code 1.
harshkrishna17 commented 2 years ago

Committed #105 but build still failing

did you try building the website locally with pkgdown::build_site() first?

below is the error from the latest:

 -- Building function reference -------------------------------------------------
Writing 'reference/index.html'
Error in library(pkg$package, character.only = TRUE) : 
  there is no package called ‘ggshakeR’
Calls: <Anonymous> ... build_site_local -> build_reference -> examples_env -> library
11 Removing worktree 11111111111111111111111111111111111111111111111111111111111
Running git worktree remove /tmp/Rtmp6t0ctX/file29932cba8b5b
Execution halted
Error: Process completed with exit code 1.

I did run pkgdown::build_site() @Ryo-N7

Ryo-N7 commented 2 years ago

... OK so? what did you get? Since that ran fine, you pushed, and then the error above happened? or...?

harshkrishna17 commented 2 years ago

Yea, I pushed the commit and the pkgdown push failed. The error message now is different from before though

harshkrishna17 commented 2 years ago

Close as fixed. Check #106