search

abhiamishra / ggshakeR

An analysis and visualization R package that works with publicly available soccer data
https://abhiamishra.github.io/ggshakeR/
MIT License
114 stars 14 forks source link

[Feature Request]: Add a "made using ggshakeR" to all plots #110

Closed abhiamishra closed 2 years ago

abhiamishra commented 2 years ago

Suggest an idea or something that can be improved.

As the title says

abhiamishra commented 2 years ago

@rithwikrajendran can you pick up some of these plots?

Look at @harshkrishna17's plot_pizza to find that we only need to add caption ggplot element to our plots.

rithwikrajendran commented 2 years ago

@rithwikrajendran can you pick up some of these plots?

Look at @harshkrishna17's plot_pizza to find that we only need to add caption ggplot element to our plots.

Yes, I would be fine picking up some of the plots. But I haven't understood the issue/requirement yet. Can you explain it a bit?

abhiamishra commented 2 years ago

Basically add a caption to plots so that anytime anyone uses ggshakeR, the plots made by us can be identified by a caption.

Allows our package to be more easily found.

Think of it like as a "Made by Rithwik" on a scatterplot, etc

rithwikrajendran commented 2 years ago

Got it. I'll work on it soon.

abhiamishra commented 2 years ago

@rithwikrajendran I'm using this as caption:

"Created using ggshakeR"

rithwikrajendran commented 2 years ago

@rithwikrajendran I'm using this as caption:

"Created using ggshakeR"

Got it!