search

abhiamishra / ggshakeR

An analysis and visualization R package that works with publicly available soccer data
https://abhiamishra.github.io/ggshakeR/
MIT License
114 stars 14 forks source link

xG timeline label should have `xG value` rather than `minute of shot` #32

Closed Ryo-N7 closed 2 years ago

Ryo-N7 commented 2 years ago

in plot_timeline() the label we have for shots/goals is the minute of that... which isn't really necessary due to the x-axis. The focus of this plot is on the xG so we should be labeling the xG value instead

Ryo-N7 commented 2 years ago

hmm no, have to re-write a considerable amount of the code to restructure it to get it to generalize for any number of goals for either team

bit more work but it's got to be done...

Ryo-N7 commented 2 years ago

also handle 'own goal' cases

Ryo-N7 commented 2 years ago

i'm also moving around the code so that the 'plot' element code like the title and themes stuff is all closer together and also happens right before the actual plot is made.

for some reason it was stuck at the top?

I've also consolidated a lot of the data pre-processing into one pipe instead of jumping around a myriad of steps and re-assigning it to the 'data' variable. much cleaner this way.

Ryo-N7 commented 2 years ago

there's no need to split the geom_*() into separate data frames as you can just use group argument but i'll work on that in a separate issue?