search

abhiamishra / ggshakeR

An analysis and visualization R package that works with publicly available soccer data
https://abhiamishra.github.io/ggshakeR/
MIT License
113 stars 14 forks source link

Fix images in "Guide to creating pizza plots" #79

Closed harshkrishna17 closed 2 years ago

harshkrishna17 commented 2 years ago

Images in plot_pizza() guide are different from the actual output of function. Basic change to pkgdown website to be done at the absolute last before release.

abhiamishra commented 2 years ago

Status on this?

harshkrishna17 commented 2 years ago

Gonna piggyback fixing the logo in the README in this issue

harshkrishna17 commented 2 years ago

@abhiamishra I'll do this as the absolute last thing before release to public. Wouldn't want the images to be changed again because of other pr's

harshkrishna17 commented 2 years ago

Reminder: Remove "distance" as a parameter for plot_pass in "Guide to Version 0.2.0" as it is no longer a parameter in the function

harshkrishna17 commented 2 years ago

Reminder: Change the guide to pitch plots as the parameter in plot_passnet has been changed

harshkrishna17 commented 2 years ago

Reminder: Add in the links to the new articles in the "Guide to version 0.2.0"

harshkrishna17 commented 2 years ago

Changed the parameter names in plot_convexhull and plot_voronoi and removed the "_plot" suffix to the title/subtitle param. Also made the necessary changes to the guides. See issue #98 (closed)