EPV testing - Githubissues

abhiamishra / ggshakeR

An analysis and visualization R package that works with publicly available soccer data

https://abhiamishra.github.io/ggshakeR/

MIT License

113 stars 14 forks source link

EPV testing #90

Closed abhiamishra closed 2 years ago

abhiamishra commented 2 years ago

Checklist

Before creating the Pull-Request, I...

[x] Ran devtools::document() and Install and Restart.
[x] Ran devtools::check() (GHA will do this but doesn't hurt to check yourself).
[ ] (If applicable) Checked changes made to website with pkgdown::build_site().
[x] Wrote commit message(s) throughout the time spent working on this branch with clear details of changes made.
[x] (If applicable) Created new tests for new functions or changes made to existing functions (Check codecov).

After all of the Github Actions Checks have finished, I...

[x] Checked lintr issues by going to the latest commit or the Checks tab.
[x] Used Squash & Merge option.
[x] Wrote in detail of all the changes made in the various commits on this branch.
[x] Added a keyword like closes #56, fixes #123 at the end of the message.
[x] Merged the Pull-Request.
[x] Deleted the branch.

abhiamishra commented 2 years ago

Duplicated testing for xT threat function on EPV function.

Included 4 tests:

Opta type
Statsbomb type
Empty dataframe
Dataframe with missing columns