search

abhidas17695 / dweb-ext

0 stars 0 forks source link

Directions to build all the code -- we can't see what you are doing to check assumptions etc #18

Closed mitra42 closed 6 years ago

mitra42 commented 6 years ago

We need directions to make bundle.js, ideally inside the dweb-ext repo, but can be a separate repo if you need that repo to just be the extension. Also if you are modifying dweb-object then the changes being made need to be in a repo, and properly checked in so we can see what you are doing.

abhidas17695 commented 6 years ago

Latest commit address this issue. All files and instructions to build the bundles included. Changes to objects folder is only at Domain.js at line 178. Load the dist folder into Chrome to use the extension.

mitra42 commented 6 years ago

Are there any changes to dweb-transports, or is this just a copy of the dweb-transports repo ?

abhidas17695 commented 6 years ago

dweb-transports is a copy of the original forked from your account. Only change is to dweb-objects in Domain.js at line 178.

mitra42 commented 6 years ago

Can you update the instructions to include the full flow ... it seems from your comment on #3 Using webpack for now. Build instructions for the current version are in README.md. Source repos at https://github.com/abhidas17695/dweb-transports/tree/ext and https://github.com/abhidas17695/dweb-objects/tree/ext will be updates as and when needed that the process for a change involves copying the code somehow (how are you doing this) from internetarchive/dweb-objects -> abhidas17695/dweb-objects -> dweb-ext/objects before this build ?

abhidas17695 commented 6 years ago

Yes I will.

mitra42 commented 6 years ago

See conversation in slack that should be here .... instructions are still reqd.