Parse missing boxes - Githubissues

abhijeetbhagat / mp4box

Python 3 port of the MP4Box tool

BSD 3-Clause "New" or "Revised" License

8 stars 9 forks source link

Parse missing boxes #6

Open abhijeetbhagat opened 5 years ago

abhijeetbhagat commented 5 years ago

Refer to http://xhelmboyx.tripod.com/formats/mp4-layout.txt and add parsers for:

[ ] mp4a
- [ ] esds
[x] avc1
- [x] avcC
[ ] sdtp
[ ] iods
[ ] sidx
[ ] moof
- [ ] mfhd
- [ ] traf
  - [ ] tfhd
  - [ ] tfdt
  - [ ] trun

agkatare commented 5 years ago

Started working on avc1, accC parsing.

SwapnilBhosale commented 5 years ago

@agkatare have you already started working on the above parsing ? Can I take AVC1?

SwapnilBhosale commented 5 years ago

I am adding avc1 box parsing.

abhijeetbhagat commented 5 years ago

I am adding avc1 box parsing.

@SwapnilBhosale, I have added an audio sample in the test folder and additional audio related boxes. Can you, instead, work on them?

agkatare commented 5 years ago

Yes, I have started working on it.

abhijeetbhagat commented 5 years ago

Yes, I have started working on it.

@agkatare thank you for working towards making a contribution to mp4box! Just a reminder - Under avc1, there are avcC and btrt boxes. btrt parsing is already done. When adding a parser for avc1, you also have to call parse_btrt(...) along with your newly implemented parse_avcc(...).

SwapnilBhosale commented 5 years ago

I am adding avc1 box parsing.

@SwapnilBhosale, I have added an audio sample in the test folder and additional audio related boxes. Can you, instead, work on them?

Yup, I am taking Audion related boxes

agkatare commented 5 years ago

Yes, I have started working on it.

@agkatare thank you for working towards making a contribution to mp4box! Just a reminder - Under avc1, there are avcC and btrt boxes. btrt parsing is already done. When adding a parser for avc1, you also have to call parse_btrt(...) along with your newly implemented parse_avcc(...).

Sure, @abhijeetbhagat I'll consider calling parse_avcc(...) under avc1 parser.

abhijeetbhagat commented 5 years ago

@agkatare, sorry, I just added parsing for the stsd, avc1, and avcc (this one in progress) boxes since i need them for the frame generation testing which i implemented.