search

abhijeetnishal / Password-Shield

Password Manager Deployed Link 👇
https://passwordshield.vercel.app
16 stars 34 forks source link

Navigate to website by clicking on website name in the card detail #169

Open The-Phoenics opened 1 month ago

The-Phoenics commented 1 month ago

Is your feature request related to a problem? Please describe. It would a better user experience if the user could navigate to the website by simply clicking on the website name in the website-password details card.

Describe the solution you'd like We can make the element (that shows website name in the card) a anchor tag and redirect the user to that website when the user clicks that element.

anchor-tag

github-actions[bot] commented 1 month ago

Hi there! Thanks for opening this issue. We appreciate your contribution to this open-source project. We aim to respond or assign your issue as soon as possible.

The-Phoenics commented 1 month ago

Hey @abhijeetnishal Can you please take a look at this issue? I would like to work on this under GSSoC'24.

abhijeetnishal commented 1 month ago

Hey @The-Phoenics, we need to verify the website also right? What if someone add incorrect url and if they redirect it will show error? Will you verify the added url?

The-Phoenics commented 1 month ago

Hey @abhijeetnishal Yes we can do a check using fetch and resulting status codes. But I think it should be totally up to the user what they want their passwords to map to.

abhijeetnishal commented 1 month ago

Yes, it depends on users also. But still add the function to check. Assigning this issue to you, good luck.

The-Phoenics commented 1 month ago

Hey @abhijeetnishal I need your help in setting up the project locally.

This is my server's .env 2024-07-28_15-36

console: problem

I could not find the /client/.env.sample which should pe pasted and configured in client/.env.local as mentioned in Application Setup section of readme

abhijeetnishal commented 1 month ago

Hey @The-Phoenics, the env for client is not correct I guess that's why the endpoint is incorrect. The filename for client is local.env and it contains NEXT_PUBLIC_BASE_URL=http://localhost:8080

I think somehow sample.env is not there I will fix that issue, sorry for that.

The-Phoenics commented 1 month ago

Hey @abhijeetnishal I've added local.env in the client directory, still unable to register error-env

abhijeetnishal commented 1 month ago

Hey @The-Phoenics, Change the file name to .env.local from local.env and restart the server.