abhijeetnishal / Password-Shield

Password Manager Deployed Link 👇
https://passwordshield.vercel.app
16 stars 34 forks source link

Add title and description for password #88

Open vansh-sardana opened 3 months ago

vansh-sardana commented 3 months ago

Describe the bug when we try to add the password for a website that has been already added, creates a new entry.

To Reproduce Steps to reproduce the behavior:

  1. Login
  2. Click on 'Add new'
  3. Add two different passwords for same website
  4. Two entries will be created for same website

Expected behavior if the same website is already listed, its password should be updated rather than creating another entry for the same.

Screenshots image

Desktop (please complete the following information):

Additional context Kindly assign me this issue under GSSOC'24 as a contributor. I would be eager to fix this up.

vansh-sardana commented 3 months ago

@abhijeetnishal if you could look into it.

abhijeetnishal commented 3 months ago

Hey @vansh-sardana, it's is possible to have 2 or more passwords consider Google, it's possible to have 2 accounts and passwords can't be checked for duplicate.

vansh-sardana commented 3 months ago

So this website should atleast have another field for a email id/username in order to differentiate between the two fields. Only having google.com and its two passwords cant serve the purpose solely. I can work on that. @abhijeetnishal

abhijeetnishal commented 3 months ago

I think there is an issue #42 for this.

But I will assign it to you as you are interested working on my project. Add title and description field as I already updated the backend, these fields are already there.

vansh-sardana commented 3 months ago

hello sir @abhijeetnishal , i needed help to fix one issue while setting up the postgresql. The server does not support SSL connections. How to fix this. i needed to run backend in order to test it.

abhijeetnishal commented 3 months ago

Hey @vansh-sardana, You can connect without SSL also. But if you want to use SSL, just remove this line: ssl: { rejectUnauthorized: false },

The dbConnect code should look like:

const client = new Client({
  connectionString: connectionString,
});

Remove the code changes once done.

saurabhbakolia commented 3 months ago

Hey @abhijeetnishal,

I want to work on this issue, if someone else is not working.

Thanks

abhijeetnishal commented 2 months ago

Hey @saurabhbakolia, are you still interested in working on this?

saurabhbakolia commented 2 months ago

Hey @saurabhbakolia, are you still interested in working on this?

Yes, I would like to work on this.

abhijeetnishal commented 2 months ago

Hey @saurabhbakolia, actually I am thinking of new design as this ui doesn't fit with these requirements. So you have any UI in your mind?

saurabhbakolia commented 2 months ago

Hey @saurabhbakolia, actually I am thinking of new design as this ui doesn't fit with these requirements. So you have any UI in your mind?

For the entire platform ? or just for the input form?

abhijeetnishal commented 2 months ago

Hey @saurabhbakolia, actually I am thinking of new design as this ui doesn't fit with these requirements. So you have any UI in your mind?

For the entire platform ? or just for the input form?

For the dashboard screen only which contains the passwords