abhijeetnishal / URLShortener

URL Shortener Deployed Link 👇🏻
https://urlsrtner.vercel.app
MIT License
37 stars 60 forks source link

Resolving Missing ShortId in the Database #109

Closed Abh-I-seK closed 4 months ago

Abh-I-seK commented 4 months ago

Describe the bug After shortening a URL, we get an URL in form of https://urlsrt.vercel.app/data. Now if we pass a arbitrary value in place of data then it shows the following. In the example below, I used the URL : https://urlsrt.vercel.app/111222

image

So, I think if in getSpecificUrl() (in server/controller/urls.js) once we find the data based on shortId then check if its null. If null, then we will redirect the user to an 404 page which will say that "This link does not exist".

And will also add link to navbar, which will redirect to homepage.

Could you please assign this issue to me under GSSOC 24.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://urlsrt.vercel.app/111222

Expected behavior The above screenshot.

Desktop (please complete the following information):

github-actions[bot] commented 4 months ago

Congratulations, @Abh-I-seK! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

abhijeetnishal commented 4 months ago

Great, Assigning this issue to you now.

You are implementing frontend and backend both right? The UI should be responsive also right?

Abh-I-seK commented 4 months ago

Great, Assigning this issue to you now.

You are implementing frontend and backend both right? The UI should be responsive also right?

Yes, I will implement both responsive frontend and backend.