search

abhijeetnishal / URLShortener

URL Shortener Deployed Link 👇🏻
https://urlsrtner.vercel.app
MIT License
37 stars 59 forks source link

Optimize whole project #19

Closed divyansh355 closed 3 months ago

divyansh355 commented 4 months ago

Optimized whole project...

abhijeetnishal commented 4 months ago

Hey @divyansh355, could you mention the changes you have done like it's a bug fix or refactoring or feature so that i can review it.

divyansh355 commented 4 months ago

Hey @divyansh355, could you mention the changes you have done like it's a bug fix or refactoring or feature so that i can review it.

▫ Used useEffect() in HomeScreen.jsx ▫ Improved error handling in dbConnect.js with some good console messages, and good chaining using await, try, catch, throw. ▫ I removed the condition while exporting the modal in urlSchema.js ▫ Write good comments in urlRoutes.js ▫ Add a length parameter in utils.js. so, a user can increase it without any hardcore value ▫ Refractor urlController.js

abhijeetnishal commented 3 months ago

Hey

Hey @divyansh355, could you mention the changes you have done like it's a bug fix or refactoring or feature so that i can review it.

▫ Used useEffect() in HomeScreen.jsx ▫ Improved error handling in dbConnect.js with some good console messages, and good chaining using await, try, catch, throw. ▫ I removed the condition while exporting the modal in urlSchema.js ▫ Write good comments in urlRoutes.js ▫ Add a length parameter in utils.js. so, a user can increase it without any hardcore value ▫ Refractor urlController.js

Hey @divyansh355, we are currently changing the dbConnect() method (as connection pooling), so apart from that changes i will review it.

abhijeetnishal commented 3 months ago

We have migrated the code from react to nextjs so i am closing this PR now.