Closed Mr-mahato closed 3 months ago
tahnks for letting me know the changes that i need to work on.
@Mr-mahato is attempting to deploy a commit to the Abhijeet's projects Team on Vercel.
A member of the Team first needs to authorize it.
I made all the changes as you have told , do i need to make another PR too.
I have done that.
Hey @Mr-mahato, could you please go throw this server code: https://github.com/abhijeetnishal/social-media-app/blob/master/server/src/controllers/userController.ts Refer this and update accordingly and update PR.
I went through the https://github.com/abhijeetnishal/social-media-app/blob/master/server/src/controllers/userController.ts repo , thoroughly , i found that everything here is modularized.
import { NextFunction, Request, Response } from "express";
return next({ statusCode: 400, message: "username already registered", });
is this same as res.status(400).json({message:"username already registered"})
i need littel help here
I went through the https://github.com/abhijeetnishal/social-media-app/blob/master/server/src/controllers/userController.ts repo , thoroughly , i found that everything here is modularized.
import { NextFunction, Request, Response } from "express";
return next({ statusCode: 400, message: "username already registered", });
is this same as res.status(400).json({message:"username already registered"}) i need littel help here
Only follow the logic for checks only. Use res.status.json here.
If you need any other help let me know
I went through the https://github.com/abhijeetnishal/social-media-app/blob/master/server/src/controllers/userController.ts repo , thoroughly , i found that everything here is modularized. import { NextFunction, Request, Response } from "express"; return next({ statusCode: 400, message: "username already registered", });
is this same as res.status(400).json({message:"username already registered"}) i need littel help here
Only follow the logic for checks only. Use res.status.json here.
If you need any other help let me know
That means will it be okay if i am having the password checks like while signing up , user most have confirm password and password. and some credential with password like having uppercase , lowercase , special character . Isn't this the only thing that i should look or there are more which needs to be updated.
That means will it be okay if i am having the password checks like while signing up , user most have confirm password and password. and some credential with password like having uppercase , lowercase , special character . Isn't this the only thing that i should look or there are more which needs to be updated.
Leave it the password check for now we can add to client side. If rest of the things are done then I will review the code
That means will it be okay if i am having the password checks like while signing up , user most have confirm password and password. and some credential with password like having uppercase , lowercase , special character . Isn't this the only thing that i should look or there are more which needs to be updated.
Leave it the password check for now we can add to client side. If rest of the things are done then I will review the code
I have done the remaing task and modularize every folder , i would be happy to code if there are any changes that i need to make .
That means will it be okay if i am having the password checks like while signing up , user most have confirm password and password. and some credential with password like having uppercase , lowercase , special character . Isn't this the only thing that i should look or there are more which needs to be updated.
Leave it the password check for now we can add to client side. If rest of the things are done then I will review the code
I have done the remaing task and modularize every folder , i would be happy to code if there are any changes that i need to make .
I will check and let you know. Are you creating a new PR?
should i create a new PR?
I guess you closed this that's why 😅
I have open a new PR.
Hi @abhijeetnishal
I've successfully completed the following tasks:
Implemented user registration endpoint (v1/auth/signup) with input validation and MongoDB storage. Created login endpoint (v1/auth/login) with database credential verification. Integrated JWT authentication with token generation, storage, and verification.
Please let me know if you'd like to test or review.