abhijeetnishal / URLShortener

URL Shortener Deployed Link πŸ‘‡πŸ»
https://urlsrtner.vercel.app
MIT License
37 stars 59 forks source link

Restructure react project into next app #30

Closed sujeetgund closed 3 months ago

sujeetgund commented 3 months ago

What does this PR do?

This PR restructures existing react app into next app. I actually didn't mean to make this PR this big but got many conflicts to restructure but I deployed it on vercel so you can check it: https://url-shortener-gssoc.vercel.app/

Features I have included in next app:

FIXES #15

vercel[bot] commented 3 months ago

@sujeetgund is attempting to deploy a commit to the Abhijeet's projects Team on Vercel.

A member of the Team first needs to authorize it.

abhijeetnishal commented 3 months ago

Hey @sujeetgund, the folder structure is changed, please follow the current folder structure of client and server both are separated. Our server should be in node.js only we don't need to migrate from node.js to Next.js only client side we need whatever it's in client folder we need to migrate to next.js not from server folder as we have separate frontend and backend.

Update these changes and then i will review again and merge it.

sujeetgund commented 3 months ago

Okay, I will make changes accordingly!

sujeetgund commented 3 months ago

@abhijeetnishal How does this project structure looks?

πŸ“url-shortener-final
    └── .env.sample
    └── .eslintrc.json
    └── πŸ“.github
    └── .gitignore
    └── CODE_OF_CONDUCT.md
    └── Learn.md
    └── next-env.d.ts
    └── next.config.mjs
    └── package-lock.json
    └── package.json
    └── postcss.config.mjs
    └── πŸ“public
        └── chain.png
        └── copy.png
        └── http.png
        └── next.svg
        └── vercel.svg
    └── Readme.md
    └── πŸ“server
    └── πŸ“src
        └── πŸ“app
            └── favicon.ico
            └── globals.css
            └── layout.tsx
            └── page.tsx
        └── πŸ“components
            └── Navbar.tsx
        └── πŸ“db
            └── index.ts
        └── πŸ“models
            └── Url.ts
    └── tailwind.config.ts
    └── tsconfig.json
abhijeetnishal commented 3 months ago

@abhijeetnishal How does this project structure looks?

πŸ“url-shortener-final
    └── .env.sample
    └── .eslintrc.json
    └── πŸ“.github
    └── .gitignore
    └── CODE_OF_CONDUCT.md
    └── Learn.md
    └── next-env.d.ts
    └── next.config.mjs
    └── package-lock.json
    └── package.json
    └── postcss.config.mjs
    └── πŸ“public
        └── chain.png
        └── copy.png
        └── http.png
        └── next.svg
        └── vercel.svg
    └── Readme.md
    └── πŸ“server
    └── πŸ“src
        └── πŸ“app
            └── favicon.ico
            └── globals.css
            └── layout.tsx
            └── page.tsx
        └── πŸ“components
            └── Navbar.tsx
        └── πŸ“db
            └── index.ts
        └── πŸ“models
            └── Url.ts
    └── tailwind.config.ts
    └── tsconfig.json

Hey @sujeetgund, As i mentioned earlier we need to completely separate client and server. Currently you focus on client folder and change to next.js with tailwind considering the initial design don't focus on server folder for now.

Refer this: https://github.com/abhijeetnishal/social-media-app here the application client folder using nextjs with tailwind.

If you have any queries let me know

sujeetgund commented 3 months ago

I have restructured it into client and server directories. Please review and merge it.

abhijeetnishal commented 3 months ago

Hey @sujeetgund, I have merged this pull request to next-tailwind-app branch, mostly it looks good to me some changes are there i will fix and let you know. Great work πŸ‘