search

abhijeetnishal / URLShortener

URL Shortener Deployed Link 👇🏻
https://urlsrtner.vercel.app
MIT License
37 stars 60 forks source link

Created an API endpoint (v1/api/urls) for getting all user urls #65

Closed atharvarekhawar closed 4 months ago

atharvarekhawar commented 4 months ago

@abhijeetnishal This PR solves issue #17

new endpoint has been created but there are few potential issues that I see in the code base -:

1.env.sample not updated with JWT_SECRET

2.token authorization is not done in other url controllers .

3.urls can be included in user schema so that extra call is eliminated while fetching all user urls.

4.userId not added to url when creating new URL.

5.standardizing the format for all endpoints eg. (v1/api/)

vercel[bot] commented 4 months ago

@atharvarekhawar is attempting to deploy a commit to the Abhijeet's projects Team on Vercel.

A member of the Team first needs to authorize it.

abhijeetnishal commented 4 months ago

After making these changes push the code to feat/server-crud branch instead of master so that i will test and make changes to code and merge to master branch.

atharvarekhawar commented 4 months ago

hey , @abhijeetnishal I have pulled changes from master branch and after solving merge conflicts have pushed the changes in this PR , you can review it now.

abhijeetnishal commented 4 months ago

hey , @abhijeetnishal I have pulled changes from master branch and after solving merge conflicts have pushed the changes in this PR , you can review it now.

Oh great👏, you are learning git.

abhijeetnishal commented 4 months ago

Hey @atharvarekhawar, could you change the merge from master to feat/server-crud branch so that i can test and merge.

abhijeetnishal commented 4 months ago

Hey @atharvarekhawar, i reviewed the code it looks good, great job, now i have to test it and merge to master

atharvarekhawar commented 4 months ago

@abhijeetnishal changed the base branch to feat/server-crud