abhijeetnishal / URLShortener

URL Shortener Deployed Link 👇🏻
https://urlsrtner.vercel.app
MIT License
37 stars 60 forks source link

Implemented login and signup for client side #66

Closed rahul-2004-json closed 4 months ago

rahul-2004-json commented 4 months ago

This pull request solves issue #45 and is ready for review

vercel[bot] commented 4 months ago

@rahul-2004-json is attempting to deploy a commit to the Abhijeet's projects Team on Vercel.

A member of the Team first needs to authorize it.

abhijeetnishal commented 4 months ago

Hey @rahul-2004-json, if you need any help let me know

rahul-2004-json commented 4 months ago

I had some problem accessing the login page and signup page routes so I did it manually I don't know why default folder route functionality is not working in next js. I tried fixing in server also but didn't work. I don't know where I am doing it wrong Pls let me know about fix for accessing those pages.

abhijeetnishal commented 4 months ago

I had some problem accessing the login page and signup page routes so I did it manually I don't know why default folder route functionality is not working in next js. I tried fixing in server also but didn't work. I don't know where I am doing it wrong Pls let me know about fix for accessing those pages.

Wait I will check it should work And what about the changes I mentioned on code review have you completed?

abhijeetnishal commented 4 months ago

Hey @rahul-2004-json, The issue is with folder structure.

Your current folder structure: Screenshot 2024-05-14 234446

Folder structure should be like this: Screenshot 2024-05-14 235400

It will looks like this after changing folder structure: Screenshot 2024-05-14 235545

Try to make changes it will work and let me know if you need some help

rahul-2004-json commented 4 months ago

I had some problem accessing the login page and signup page routes so I did it manually I don't know why default folder route functionality is not working in next js. I tried fixing in server also but didn't work. I don't know where I am doing it wrong

rahul-2004-json commented 4 months ago

Thanks @abhijeetnishal for helping with route related problem ,I will implement the changes mentioned in pull request review.

abhijeetnishal commented 4 months ago

Thanks @abhijeetnishal for helping with route related problem ,I will implement the changes mentioned in pull request review.

No problem @rahul-2004-json. If you need any help let me know

rahul-2004-json commented 4 months ago

Hey @rahul-2004-json, The issue is with folder structure.

Your current folder structure: Screenshot 2024-05-14 234446

Folder structure should be like this: Screenshot 2024-05-14 235400

It will looks like this after changing folder structure: Screenshot 2024-05-14 235545

Try to make changes it will work and let me know if you need some help

I made changes as you suggested but don't know why I am not able to access that route .. my server is up and running

abhijeetnishal commented 4 months ago

Hey @rahul-2004-json, just go to the route as mentioned in the output image. It's working as I share the image

rahul-2004-json commented 4 months ago

Hi @abhijeetnishal

I hope this message finds you well.

I wanted to inform you that due to my ongoing exams and my most of the time going into preparation, I am currently unable to contribute to the project. If you need to assign the particular issue I was working on to someone else to ensure the project's progress, please feel free to do so. I don't want the progress to be halted because of me.

The last pull request I made had changes which you told me to do , you can continue from there if you feel it's right.

Thank you for your understanding.

abhijeetnishal commented 4 months ago

Hey @rahul-2004-json, I guess you closed all the PR, could you create a PR and push the changes have you done till now. I will review

abhijeetnishal commented 4 months ago

Best of luck for your exams.

rahul-2004-json commented 4 months ago

Hey @rahul-2004-json, I guess you closed all the PR, could you create a PR and push the changes have you done till now. I will review

I made a pull request #101 . Please check !

abhijeetnishal commented 4 months ago

Hey @rahul-2004-json, I guess you closed all the PR, could you create a PR and push the changes have you done till now. I will review

I made a pull request #101 . Please check !

Great I will review and merge to development branch so you become contributer of the project as I don't want your hard work wasted.

rahul-2004-json commented 4 months ago

Hey @rahul-2004-json, I guess you closed all the PR, could you create a PR and push the changes have you done till now. I will review

I made a pull request #101 . Please check !

Great I will review and merge to development branch so you become contributer of the project as I don't want your hard work wasted.

Thank you soo much @abhijeetnishal for this kind gesture.

You were really patient, understanding and humble project owner I worked with ❤️

abhijeetnishal commented 4 months ago

No problem @rahul-2004-json, i understand.

Thanks for your kind words 😊

If you need any help in future, let me know. My discord id is - @abhijeetnishal