search

abhijeetnishal / URLShortener

URL Shortener Deployed Link 👇🏻
https://urlsrtner.vercel.app
MIT License
38 stars 62 forks source link

created endpoint for getting all user Urls and added middleware to access token #68

Closed atharvarekhawar closed 2 months ago

atharvarekhawar commented 2 months ago

This PR solves issue #17

vercel[bot] commented 2 months ago

@atharvarekhawar is attempting to deploy a commit to the Abhijeet's projects Team on Vercel.

A member of the Team first needs to authorize it.

atharvarekhawar commented 2 months ago

@abhijeetnishal all changes made that you told , as well as middleware is implemented

abhijeetnishal commented 2 months ago

Hey @atharvarekhawar, i have added comments regarding your doubts on previous PR. I request you to go through the basics of API and backend concepts with Node.js (express) so that you can do it easily as fundamentals are important. Focus more on learning rather than completing task open source is mainly for this.

I will review the code tomorrow till then try to go through the basics.

atharvarekhawar commented 2 months ago

sure @abhijeetnishal

abhijeetnishal commented 2 months ago

Hey @atharvarekhawar, could you push the changes to same PR #65, don't create separate PR until it's necessary. Also don't force push if some issues arises, let me know.

abhijeetnishal commented 2 months ago

Once done close this PR

atharvarekhawar commented 2 months ago

hey , @abhijeetnishal I had pushed changes to both the PR at the time , you can check #65 , changes are already present.

I will be closing this PR now.

abhijeetnishal commented 2 months ago

hey , @abhijeetnishal I had pushed changes to both the PR at the time , you can check #65 , changes are already present.

I will be closing this PR now.

hey , @abhijeetnishal I had pushed changes to both the PR at the time , you can check #65 , changes are already present.

I will be closing this PR now.

Great @atharvarekhawar, I will review today