middleware added for validating the url

[RoshanAnsy]

we added the new file middleware that is validates the given url first. If the url is valid then it call next functions for shorten the url.

if the url is not valid then it return to client is that entered url is not valid. Additionally, we have also improved the code formatting

Solves #58

[vercel[bot]]

@RoshanAnsy is attempting to deploy a commit to the Abhijeet's projects Team on Vercel.

A member of the Team first needs to authorize it.

[abhijeetnishal]

Hey @RoshanAnsy, we haven't discussed about this issue. Please don't create a PR directly it will waste you work if the issue is not necessary

[RoshanAnsy]

please schedule the meeting for it.

[abhijeetnishal]

We have discussion section on github we can discuss there

[abhijeetnishal]

Hey @RoshanAnsy, have you tested this, is it working i.e. it is validating URL's?

[RoshanAnsy]

Yes it is working.

[abhijeetnishal]

Hey @RoshanAnsy, i just checked it's not working

[RoshanAnsy]

You are checking the request payload, but you should check the response options.

[abhijeetnishal]

But the URL I have added is invalid it should show invalid right? Leave it request response option for now

[abhijeetnishal]

I tried with this URL https:/github.com/ but it still shortened it.

[RoshanAnsy]

when we hit the request to browsers it automatically correct certain mistakes in URLs. For example, they might interpret http:/github.com as http://github.com by adding the missing slash.

And as the result it gives you corrects url.

[abhijeetnishal]

Ok @RoshanAnsy, I will test it with other URL's and let you know. If it works then I will review the code and merge.

[RoshanAnsy]

All changes have been made as you mentioned.

[abhijeetnishal]

Hey @RoshanAnsy, resolve the conflict as I mentioned in the first comment else it will not merge.

[RoshanAnsy]

I think as you mentioned I did changes in the code base but if some conflict is there it may be due to your code base structure has changed at the major level [ I am working with your old code base may be that's the reason of conflict ].

After all that if you want to that I resolve the conflict please schedule the meeting for it I can fix it. It does not take more time I think 10 minutes is enough for it. I think I don't have permission to resolve the conflict. Look the button of Resolve conflict is not working for me.

[abhijeetnishal]

Hey @RoshanAnsy, this happens because of other contributers add code.

If you are using vscode:

1. Pull the latest code using command: git pull origin master
2. In vs code it will show files with conflict then open that file and then you will get two options accept current and accept incoming. Select accept current if you have changed the code else select incoming.
3. Once done select confirm merge.
4. Finally commit the changes, it will fix this issue for sure.

[RoshanAnsy]

Have you have checked my latest commit bz for me no any conflict is visible in my vs code.

[RoshanAnsy]

I resolve the conflict please check it.

[abhijeetnishal]

Hey @RoshanAnsy, there are some issues/suggestion:

1. isValidURL is not imported in urls routes file that's why its failing to start the server.
2. Toast notification not added for invalid URL.
3. Try to use prettier for code formatting to structure code.
4. Avoid adding success from response, success/failure depends on http status code.

Good luck.

Thanks for contributing.