search

abhijithvijayan / web-extension-starter

🖥🔋Web Extension starter to build "Write Once Run on Any Browser" extension
MIT License
1.97k stars 169 forks source link

Node-sass is deprecated #86

Closed arnaumanyosa closed 1 year ago

arnaumanyosa commented 2 years ago

Warning: LibSass and Node Sass are deprecated. While they will continue to receive maintenance releases indefinitely, there are no plans to add additional features or compatibility with any new CSS or Sass features. Projects that still use it should move onto Dart Sass.

Move to sass package.

Would be any issue on webpack, etc?

arnaumanyosa commented 2 years ago

Apparently by removing node-sass and installing sass is enough and it everything works as expected.

https://stackoverflow.com/questions/63943756/replace-node-sass-with-dart-sass-in-create-react-app-v3-x

Egor-Koldasov commented 1 year ago

Why the issue is closed though? package.json still has the deprecated node-sass. I wasn't even able to run the project until I replaced the dependency in my fork.

arnaumanyosa commented 1 year ago

@Egor-Koldasov Good question, probably I was busy at that time or something and just added the info.

@abhijithvijayan Here is a PR to fix this https://github.com/abhijithvijayan/web-extension-starter/pull/94

abhijithvijayan commented 1 year ago

this is resolved.