abhijithvijayan / wext-manifest-loader

Webextension Manifest Generator that you specify `manifest.json` properties to appear only in specific browsers and environment
https://github.com/abhijithvijayan/web-extension-starter
MIT License
25 stars 5 forks source link

__dev__ and __prod__ don't work combined or in nested keys #12

Closed lostfictions closed 3 years ago

lostfictions commented 3 years ago

Hi there, thanks for this loader! I've noticed that when i do this

  "__firefox__applications": {
    "gecko": {
      "__dev__id": "dev-extension",
      "__prod__id": "<full extension id>"
    }
  },

__dev__id is not getting substituted correctly in development (and __prod__id doesn't get removed). An alternate formulation like this doesn't work either:

  "__dev____firefox__applications": {
    "gecko": {
      "id": "dev-extension"
    }
  },
  "__prod____firefox__applications": {
    "gecko": {
      "id": "<full extension id>"
    }
  },

Any ideas for how to resolve this problem? I'd like a stable temporary ID for opening devtools by default.

abhijithvijayan commented 3 years ago

Bug confirmed.

abhijithvijayan commented 3 years ago

Fixed in v2.3.0

Screenshot_20210221_132120

lostfictions commented 3 years ago

Amazing, thank you!