search

abhijitparida / bunk

The unofficial attendance calculator app for ITER
MIT License
20 stars 24 forks source link

Add adaptive launcher icon #23

Open abhijitparida opened 6 years ago

abhijitparida commented 6 years ago

Source material:

  1. https://github.com/abhijitparida/bunk/blob/master/promo/logo.svg
  2. https://github.com/abhijitparida/bunk/blob/master/promo/playstore%20logo.png
jashasweejena commented 6 years ago

I would like to work on this :)

abhijitparida commented 6 years ago

Sure, go ahead! But please keep the existing launcher icons as they are.

jashasweejena commented 6 years ago

Sure, go ahead! But please keep the existing launcher icons as they are.

okay!

jashasweejena commented 6 years ago

Actually was facing a couple of issues, probably because I recently updated to the latest Android Studio 3.2. Could not find aapt2-proto.jar (com.android.tools.build:aapt2-proto:0.3.1). this is one of 'em. Fixed it by keeping google() above jcenter() on lines 6 in project level build.gradle. Should I make a separate PR for those? Another change I made was updated distributionUrl in gradle.properities to point to gradle version 4.10.2. Also there's a warning saying The specified Android SDK Build Tools version (27.0.3) is ignored, as it is below the minimum supported version (28.0.3) for Android Gradle Plugin 3.2.1. Android SDK Build Tools 28.0.3 will be used. What do I do about 'em? Thanks for your time 😃

abhijitparida commented 6 years ago

Make a separate PR.

jashasweejena commented 6 years ago

Make a separate PR.

Will one PR do? Or do I need to make more than one?

abhijitparida commented 6 years ago

Just one will do. Something like "Update build config for Android Studio 3.2".

abhijitparida commented 6 years ago

You might also have to modify .travis.yml if you are going to change the SDK Build Tools version.

jashasweejena commented 6 years ago

Just one will do. Something like "Update build config for Android Studio 3.2".

Just did one! Please check.

jashasweejena commented 6 years ago

You might also have to modify .travis.yml if you are going to change the SDK Build Tools version.

Oh. Android Studio didn't throw a warning or something tho!