search

abhikmitra / ng-joyride

Angular Joyride Directive for creating custom introductions to websites
126 stars 68 forks source link

joyride not working with jQuery3 #67

Open schuesslerf opened 8 years ago

schuesslerf commented 8 years ago

I just noticed, that ng-joyride is not working with jQuery3 yet, I tried for hours to get it working until I figured out the error. In ng-joyride.js, line 473 you write "if ($fkEl.size() === 0) {", but size() is deprecated since jQuery 1.8, and it v3 it doesn't seem to work at all any more. If changing .size() to the attribute .length it works fine, but I'm now using jQuery 2.2.4, where it's working without changing anything as well.

Please fix that for the next version (so change .size() to .length), so it works with jQuery3 as well.

seanlip commented 8 years ago

To confirm, I just noticed this as well -- it looks like the size() function got deprecated in jQuery v1.8, and removed entirely in v3.0 (see this link). It does look like the correct fix would be to change .size() on line 473 to .length.

seanlip commented 8 years ago

Update: I've created a pull request in #68 to fix this.

/cc @abhikmitra

ghettosoak commented 7 years ago

bump!

ahmed-wagdi commented 7 years ago

I created a joyride directive which doesn't rely on jquery or bootstrap, you can check it out here: https://github.com/ahmed-wagdi/angular-joyride

Deklin commented 7 years ago

+1 on this as well.