search

abhikmitra / ng-joyride

Angular Joyride Directive for creating custom introductions to websites
126 stars 68 forks source link

Fix #67: make ng-joyride work with jQuery v3.0. Add LICENSE file. #68

Closed seanlip closed 7 years ago

Deklin commented 7 years ago

@seanlip any chance of fixing the conflicts so this can be merged?

seanlip commented 7 years ago

Hi @deklin -- I'd be happy to, but I'm not sure the author is still maintaining the repo. I sent this PR in almost a year ago, and emailed the author, but never got any response...

Deklin commented 7 years ago

I created a PR as well. I may switch to angular-joyride but will need to update that to support jquery style selectors. This one handled conditionals better for responsive layouts so I could use :hidden and :visible selectors.

I wonder if this is still being maintained

abhikmitra commented 7 years ago

Sorry guys . I have been extremely busy !. But I did merge your PR.

Thanks a lot for helping me out !

abhikmitra commented 7 years ago

@seanlip Can you fix the conflicts ?

seanlip commented 7 years ago

Thanks @abhikmitra! Sure, I'll try and take a look tonight when I get back from work.

seanlip commented 7 years ago

OK -- I did take a quick look at this, but there are indeed merge conflicts, and resolving them correctly without breaking things will require more investigation than I have time for at the moment, I'm afraid.

So, I'm going to close this PR. However, @Deklin @abhikmitra: if you'd like to make further changes to the library based on the ones in this PR, please feel free to do so. Thanks!

Deklin commented 7 years ago

@seanlip I have opened a PR relating to your PR. https://github.com/abhikmitra/ng-joyride/pull/80 Which was subsequently merged.