search

abhikmitra / ng-joyride

Angular Joyride Directive for creating custom introductions to websites
126 stars 68 forks source link

joyrideTitle button text as config parameter (already existing stored… #73

Closed Hazarapet closed 8 years ago

Hazarapet commented 8 years ago

button texts are config parameters.I need to show another texts.already existing texts are used as by default

abhikmitra commented 8 years ago

Looks good. Can u remove workspace.xml changes ( i need to remove it here also ) and include some updates in the documentation

Hazarapet commented 8 years ago

I wondered why haven't you put .idea directory in .gitignore file. That's not useful.you can remove it and put into git ignore

Hazarapet commented 8 years ago

by the way I've changed only for "title" type.maybe will be good to change for all types. (I just needed to change only for title types)

abhikmitra commented 8 years ago

Thats ok . You can just add the new configuration in the title step part of the documentation.

Hazarapet commented 8 years ago

Should I make new pull request for both (remove this), or only just for documentation