Change flattenJSONObject to return POSIX compliant names

abhilash1in / aws-secrets-manager-action

Use secrets from AWS Secrets Manager as environment variables in your GitHub Actions workflow

MIT License

68 stars 43 forks source link

Closed cbui closed 3 years ago

cbui commented 3 years ago

cbui commented 3 years ago

Should I remove the lock?

abhilash1in commented 3 years ago

@cbui Thank you for your contribution!

Should I remove the lock?

Yes, please. I'll update package-lock.json in a separate commit after bumping up a few dependencies.

The PR looks good on the first glance. Will take another look once package-lock.json is removed and merge it in.

cbui commented 3 years ago

Removed.

@cbui Thank you for your contribution!

Thank you for this action 🥇

emmanuelnk commented 3 years ago

@cbui @abhilash1in Just FYI I don't think this PR is working