search

abhilash1in / aws-secrets-manager-action

Use secrets from AWS Secrets Manager as environment variables in your GitHub Actions workflow
MIT License
68 stars 43 forks source link

Standard Credentials/Region handling for AWS #27

Closed avivek closed 2 years ago

avivek commented 2 years ago

AWS SDK's internally have a way of getting the credentials using inherent search behaviour. This inherent search behaviour supports IAM instance profile, environment variables etc. Please refer to below link for the default credential provider chain: https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/CredentialProviderChain.html#defaultProviders-property

In the space of github actions, it is common to get credentials using the aws-actions/configure-aws-credentials@v1 Any subsequent steps just work by leveraging the inherent credential search behaviour and there is no need to pass the credentials as input values.

Please refer below link for an example: https://github.com/aws-actions/amazon-ecs-deploy-task-definition#credentials-and-region

Do you think this behaviour can be adapted into this library??

abhilash1in commented 2 years ago

@avivek checkout the development/2.0.0 branch and let me know if that’s what you’re looking for.

avivek commented 2 years ago

Yes that is what I was looking for. Thanks. Any idea on when to look for the 2.0 release??

mydea commented 2 years ago

FYI the development/2.0.0 branch is also working nicely for us with the OpenID integration of aws-actions/configure-aws-credentials@v1. Would love to see a proper 2.0 release :tada:

abhilash1in commented 2 years ago

Thanks all for validating the release candidate.

v2.0.0 is now released 🎉