search

abhilash1in / aws-secrets-manager-action

Use secrets from AWS Secrets Manager as environment variables in your GitHub Actions workflow
MIT License
68 stars 43 forks source link

Noisy POSIX warning #32

Closed oschlegel closed 2 years ago

oschlegel commented 2 years ago

Hi, i'm getting a lot of warnings from your action like "One of the secrets has a name that is not POSIX compliant...", because basically all my secrets are not POSIX compliant. But since the conversion behavior is already documented in the readme and works fine i think it would be ok to use a debug message instead of a warning, this way it can still help to analyze and track down issues but doesn't clutter the workflow logs.

jbabala-costa commented 2 years ago

Hi, I have exactly the same issue. Could we introduce flag to suppress such warnings?

abhilash1in commented 2 years ago

Will be fixed with release 2.1.0 (coming soon, today or tomorrow).

sharat87 commented 2 years ago

Hey, looks like this warning is still there. Can you confirm if I'm doing something wrong here please?

Screenshot 2022-06-15 at 14 23 15

The variables do actually load and work fine though.

Thank you for your work.

abhilash1in commented 2 years ago

@sharat87 you need to set disable-warnings: true in order to disable and suppress POSIX warnings.

sharat87 commented 2 years ago

Hey @abhilash1in, thanks for sharing that. But wouldn't that hide all POSIX warnings? Is it possible to just hide this one particular warning?