search

abhilash1in / aws-secrets-manager-action

Use secrets from AWS Secrets Manager as environment variables in your GitHub Actions workflow
MIT License
68 stars 43 forks source link

POSIX string replacement for secretNames #6

Closed jcam closed 4 years ago

jcam commented 4 years ago

The workflow files and most shells do not support non-word characters for environment variable keys, so accessing those variables can prove difficult or impossible. This change will cause a second variable to be set that is POSIX compliant

See also: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_235

jcam commented 4 years ago

I like your changes here, thanks!