search

abhilash1in / aws-secrets-manager-action

Use secrets from AWS Secrets Manager as environment variables in your GitHub Actions workflow
MIT License
68 stars 43 forks source link

Align Credentials Input to AWS #8

Closed aaronfagan closed 4 years ago

aaronfagan commented 4 years ago

Hello,

Ive noticed that when using AWS provided Actions, credentials are passed like this:

aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY }}
aws-secret-access-key: ${{ secrets.AWS_ACCESS_SECRET }}
aws-region: ${{ secrets.AWS_REGION }}

Note the dashes - while here, they are passed with underscores:

aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY }}
aws_secret_access_key: ${{ secrets.AWS_ACCESS_SECRET }}
aws_region: ${{ secrets.AWS_REGION }}

Wondering if it makes sense to align with the provider whose service is actually being used?

Thanks!

aaronfagan commented 4 years ago

Suggested fix - change src/constants.ts to: 

export enum Inputs {
  AWS_ACCESS_KEY_ID = 'aws-access-key-id',
  AWS_SECRET_ACCESS_KEY = 'aws-secret-access-key',
  AWS_REGION = 'aws-region',
  SECRETS = 'secrets',
  PARSE_JSON = 'parse-json'
}
abhilash1in commented 4 years ago

Makes sense. Feel free to submit a pull request 🙂

If not, I'll get to this soon.

aaronfagan commented 4 years ago

PR Submitted: https://github.com/action-factory/aws-secrets-manager-action/pull/10

Thanks!