search

abhinaba-ghosh / playwright-lighthouse

:performing_arts:: Playwright Lighthouse Audit
https://www.npmjs.com/package/playwright-lighthouse
MIT License
240 stars 28 forks source link

Fix passing in custom port #12

Closed badsyntax closed 3 years ago

badsyntax commented 3 years ago

Thanks for the library! I'm using it in my project but noticed a bug where it's not passing the custom port through to lighthouse.

It's quite a severe bug as this prevents me from using the library with playwright-test, as playwright-test will run in parallel and I need to assign unique ports per lighthouse tests.

I've updated the tests to test this change.

I'd appreciate a new release as soon as possible. Many thanks.

abhinaba-ghosh commented 3 years ago

Thanks for the PR. Would you mind updating the readme references as well?

badsyntax commented 3 years ago

It's not clear what needs to be updated in the README. The fix now aligns with the info in the README. Happy to update it if you let me know what you want updating...

abhinaba-ghosh commented 3 years ago

Hi @badsyntax , the changes are available in version 2.0.3 Kindly update.

badsyntax commented 3 years ago

Awesome thanks @abhinaba-ghosh !