search

abhinaba-ghosh / playwright-lighthouse

:performing_arts:: Playwright Lighthouse Audit
https://www.npmjs.com/package/playwright-lighthouse
MIT License
240 stars 28 forks source link

[ADDED] ~minor :sparkles: Resolving with report, documented in README.md #21

Closed manuman94 closed 2 years ago

manuman94 commented 2 years ago

This solves #8 and #19 issues.

Basically the playAudit method now resolves with the Lighthouse report object.

Contact me if you have any doubt.

Thanks!

abhinaba-ghosh commented 2 years ago

@manuman94 thanks for the PR. Would you mind checking the static analysis failure?

manuman94 commented 2 years ago

Hi, I don't know why is it complaining.

I don't think that is an unnecessary block, it's a declaration of an anonymous object. Could you explain how can I fix it?

Thanks!

manuman94 commented 2 years ago

I changed the code a little. I do not agree with the change but this should fix the error hehe

Is the code review passing now?

abhinaba-ghosh commented 2 years ago

The changes are available in v2.1.0 :tada:

manuman94 commented 2 years ago

Nice!

Thank you for such an awesome library @abhinaba-ghosh