Closed vibhorkrishna closed 3 years ago
Thanks for your contribution @vibhorkrishna
I've reviewed your work, it looks good, but it would be even better if you can make these few changes...
I've made the following changes:
Great work @vibhorkrishna Once you do the following changes I'll merge it, thanks a lot for your contribution!
y_test
from test dataset as you have done for X_test
and then you can use sklearn metrics module for (y_test, y_pred)
to compute accuracy, confusion matrix and whatever you want. There is no y_test in test dataset. We only know the accuracy of the y_pred when we submit y_pred to kaggle submissions. Otherwise I would have calculated confusion matrix. I have written the accuracy of each model in README file by submitting my y_pred values one by one for each model in Kaggle.
Got it. Then,
train_test_split
from the train data itself and use that for validation. I've made the following changes:
As this issue is not in hacktoberfest. Therefore please label my pull request as hacktoberfest-accepted
Sure, Thanks for your contribution @vibhorkrishna
@vibhorkrishna Leave a star to help out this repo's visibility, if interested.
Done
I have done this problem using various ML models and have used only basic knowledge of ML so that it is easy for beginners to understand. I have also explained the problem in readme file. Please add hacktoberfest-accepted label to this pull request