search

abhinav2712 / Planets.io

A threeJS webapp made for better visualization of rotation speeds, texture and visuals etc of planets
https://solarplanetsio.netlify.app
0 stars 1 forks source link

Responsive for mobile screen solved. #3

Closed Rishav1707 closed 1 year ago

Rishav1707 commented 1 year ago

This PR fixes the following issues:-

closes #1

Changes made:-

abhinav2712 commented 1 year ago

@Rishav1707 It looks like you have removed the other items(earth,mars..) in nav bar, can you tell if you have made them into the "hamp burger" option as well?

Rishav1707 commented 1 year ago

No, I have not made the hamburger option. I only worked on responsiveness in mobile view. @abhinav2712

Rishav1707 commented 1 year ago

The navbar items were not removed, I hide the navbar items in mobile view. It will shown up after the screen crossed 600px.

abhinav2712 commented 1 year ago

@Rishav1707 If possible, make the hamburger option, would be a great practice for you, take a day or two! Happy hacking!

Rishav1707 commented 1 year ago

OK @abhinav2712

Rishav1707 commented 1 year ago

Screenshot 2022-12-14 164511 @abhinav2712 Hamburger option is added to the mobile screen.

abhinav2712 commented 1 year ago

@Rishav1707 Great work! Your PR has been merged to the master, feel free to point out more issues and work on it if you want, till then I will see what more enhancements we can make to it. Happy Hacking!

Rishav1707 commented 1 year ago

Thank you @abhinav2712