Open kloczek opened 11 months ago
abhinavsingh
commented
7 months ago @kloczek This has now been fixed, due to stale nature of the repository, workflows started to fail due to upstream changes. This has now been fixed in the develop branch
kloczek
commented
6 months ago Just tested 2.4.4 and issue still is not resolved. Here is the patch
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -209,11 +209,11 @@
# -- Options for extlinks extension ------------------------------------------
extlinks = {
- 'issue': (f'{github_repo_url}/issues/%s', '#'), # noqa: WPS323
- 'pr': (f'{github_repo_url}/pull/%s', 'PR #'), # noqa: WPS323
- 'commit': (f'{github_repo_url}/commit/%s', ''), # noqa: WPS323
+ 'issue': (f'{github_repo_url}/issues/%s', '#%s'), # noqa: WPS323
+ 'pr': (f'{github_repo_url}/pull/%s', 'PR #%s'), # noqa: WPS323
+ 'commit': (f'{github_repo_url}/commit/%s', '%s'), # noqa: WPS323
'gh': (f'{github_url}/%s', 'GitHub: '), # noqa: WPS323
- 'user': (f'{github_sponsors_url}/%s', '@'), # noqa: WPS323
+ 'user': (f'{github_sponsors_url}/%s', '@%s'), # noqa: WPS323
}
# -- Options for linkcheck builder -------------------------------------------Please let me know if you want this patch as PR.
kloczek
commented
6 months ago kloczek
commented
6 months ago BTW it would be good to drop python<=3.7 support by filter all code over 'pyupgrade --py38-plus`.
abhinavsingh
commented
6 months ago @kloczek Thank you for checking back on it. Can you please share your machine/OS details so that I can try to reproduce the same. A PR will certainly be of great help 👍
I agree at some point we might have to drop support for outdating py3 versions. But IIUC, proxy.py cannot drop support for <= 3.7 because several dependants use proxy.py for exactly this reason. Also FWIW, we have workflows/tests for <=3.7 and they seem to be holding on for now :D
kloczek
commented
6 months ago Can you please share your machine/OS details
This issue has nothing to do with machine/OS details. This issue is ONLY related to used sphinx.
In this case I'm using sphinx 7.2.6.
abhinavsingh
commented
6 months ago Can you please share your machine/OS details
This issue has nothing to do with machine/OS details. This issue is ONLY related to used
sphinx. In this case I'm usingsphinx7.2.6.
Which means you are not using versions pinned by proxy.py and likely hence the issue. Under docs/requirements.txt we have sphinx==4.3.2
Try make lib-doc , lemme know if this helps.
kloczek
commented
6 months ago This +3 years old version is no longer supported by any Linux/*BSD/Solaris distro.
Looks like something is wrong and documentation build fails.
List of installed modules in build env:
```console Package Version ----------------------------- ------- alabaster 0.7.13 Babel 2.14.0 build 1.0.3 charset-normalizer 3.3.2 click 8.1.7 cppclean 0.13 distro 1.8.0 dnf 4.18.2 docutils 0.20.1 exceptiongroup 1.1.3 gpg 1.23.2 idna 3.6 imagesize 1.4.1 importlib-metadata 7.0.1 importlib-resources 6.1.1 incremental 22.10.0 iniconfig 2.0.0 installer 0.7.0 Jinja2 3.1.2 libdnf 0.72.0 markdown-it-py 3.0.0 MarkupSafe 2.1.3 mdit-py-plugins 0.4.0 mdurl 0.1.2 myst-parser 2.0.0 packaging 23.2 pbr 5.11.1 pluggy 1.3.0 Pygments 2.17.2 pyproject_hooks 1.0.0 pytest 7.4.3 python-dateutil 2.8.2 pytz 2023.3 PyYAML 6.0.1 requests 2.31.0 setuptools 69.0.3 setuptools-scm 8.0.4 setuptools-scm-git-archive 1.4 six 1.16.0 snowballstemmer 2.2.0 Sphinx 7.1.2 sphinxcontrib-apidoc 0.3.0 sphinxcontrib-applehelp 1.0.4 sphinxcontrib-devhelp 1.0.5 sphinxcontrib-htmlhelp 2.0.4 sphinxcontrib-jsmath 1.0.1 sphinxcontrib-qthelp 1.0.3 sphinxcontrib-serializinghtml 1.1.9 sphinxcontrib-towncrier 0.3.1a3 tomli 2.0.1 towncrier 23.11.0 typing_extensions 4.9.0 urllib3 1.26.18 wheel 0.42.0 zipp 3.17.0 ```