search

abhishek-ram / django-pyas2

AS2 file transfer Server built on Python and Django.
https://django-pyas2.readthedocs.io
GNU General Public License v3.0
78 stars 31 forks source link

Add post_receive and post_send signals #18

Closed loop0 closed 4 years ago

loop0 commented 4 years ago

This PR adds two signals post_receive and post_send. They are dispatched every time the run_post_receive and run_post_send are called. This helps in case we already have our logic inside the same project, therefore not needing to call a shell command and just hook receivers to these signals.

codecov[bot] commented 4 years ago

Codecov Report

Merging #18 into master will increase coverage by 0.31%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   90.94%   91.26%   +0.31%     
==========================================
  Files          13       15       +2     
  Lines         983     1019      +36     
==========================================
+ Hits          894      930      +36     
  Misses         89       89
Impacted Files Coverage Δ
pyas2/utils.py 94.59% <100%> (+0.84%) :arrow_up:
pyas2/signals.py 100% <100%> (ø)
pyas2/tests/test_signals.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e93212f...cb35021. Read the comment docs.

loop0 commented 4 years ago

Sorry, I'm closing this PR because I figured out we can do some changes only in our code without upstream changes. Thanks for your work! I hope I can contribute more in the future.