search

abhishek-ram / django-pyas2

AS2 file transfer Server built on Python and Django.
https://django-pyas2.readthedocs.io
GNU General Public License v3.0
78 stars 31 forks source link

Handle Django Warning. Remove pylama temporarily from pytest (compati… #64

Closed chadgates closed 3 years ago

chadgates commented 3 years ago

…bility issue) and upgrade versions of packages.

codecov[bot] commented 3 years ago

Codecov Report

Merging #64 (7b4d04c) into master (59cebe6) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files          11       11           
  Lines         576      576           
=======================================
  Hits          562      562           
  Misses         14       14
Impacted Files Coverage Δ
pyas2/migrations/0001_initial.py 100.00% <ø> (ø)
pyas2/utils.py 100.00% <ø> (ø)
pyas2/views.py 97.84% <ø> (ø)
pyas2/models.py 96.06% <100.00%> (ø)
pyas2/urls.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4ba5120...7b4d04c. Read the comment docs.

abhishek-ram commented 3 years ago

Looks good but why did we have to comment out pylama?

chadgates commented 3 years ago

https://github.com/klen/pylama/pull/189 <- this pull request is unfortunately still open and pytest fails in the current version. I could not find a workaround. Maybe bumping pytest was not a good idea ?

abhishek-ram commented 3 years ago

Yeah, lets not upgrade pytest unless there is a reason to do it.