search

abhishek-ram / django-pyas2

AS2 file transfer Server built on Python and Django.
https://django-pyas2.readthedocs.io
GNU General Public License v3.0
78 stars 31 forks source link

Progress log for messages - bring back from pyas2 ? #69

Closed chadgates closed 2 years ago

chadgates commented 2 years ago

I do found the logging information useful that existed in pyas2. Is there a particular reason that this functionality did not make it into django-pyas2 or should we work on bringing it back in some form ?

pyas2_log
abhishek-ram commented 2 years ago

I thought it was not useful, i mean all you need to know is if the message was sent successfully or not and if it failed what was the reason it failed.

chadgates commented 2 years ago

In some cases, the reason was not clear to me. "Failed to parse AS2 message" and "Failed to parse AS2 MDN" exceptions are hard to determine what actually went wrong. But I do get your point and probably the logs won't help in such cases either.

abhishek-ram commented 2 years ago

Yes, those error messages are not useful. We do store tracebacks as well in some places, we just need to make sure that we are doing it everywhere.