search

abhishek-ram / pyas2-lib

AS2 Library for building and parsing Messages and MDNs
GNU General Public License v3.0
43 stars 28 forks source link

DES3 168 Support #45

Closed JVBorges closed 2 years ago

JVBorges commented 2 years ago

I'm building a AS2 server using your libary, and one of the partners requires using DES3 168 for encrypting the data.

I saw on the code that has support for the 192 version, but not for the 168. I was wondering if it's possiblie to add the 168 version.

JVBorges commented 2 years ago

I've add it in the constants, and it's seems to work, but I'm not really sure if it's the correct way to do it.

image

abhishek-ram commented 2 years ago

Yes, that should do it. Add a test case for this and raise a PR please

JVBorges commented 2 years ago

It won't be necessary anymore. I've search it up about DES encryption and found out that DES3 192 is basically the DES3 168. DES only uses 56 bits but asks for 64, 8 bits are discarded or used for parity.

Thanks anyway, great lib btw