abhishek-ram / pyas2-lib

AS2 Library for building and parsing Messages and MDNs

GNU General Public License v3.0

43 stars 28 forks source link

Option to pass custom domain for message-id generation #51

Closed robincsamuel closed 2 years ago

robincsamuel commented 2 years ago

50

robincsamuel commented 2 years ago

Makes sense. I’ll update.

robincsamuel commented 2 years ago

@abhishek-ram Pushed the updated code and unit tests. Please check.

robincsamuel commented 2 years ago

@abhishek-ram Gentle reminder :)

robincsamuel commented 2 years ago

Thanks, @abhishek-ram! I see the tests are failing for some reason, please let me know if that's something I broke, or maybe I can fix it. I ran the test suite before pushing and it was fine.

abhishek-ram commented 2 years ago

I do not think it was your change, It looks like a version of a library got updated or something not sure. If you can figure it out that would be great.

robincsamuel commented 2 years ago

@abhishek-ram Yeah, it's not my change. I figured out the reason, the latest tests were executed using pylama@8.3.7 and our previous test execution was using pylama@8.3.8.

I just compared these two versions, there's a line change and that's exactly where the tests are failing.

abhishek-ram commented 2 years ago

can we freeze the version of pylama in setup.py -> test_requires

robincsamuel commented 2 years ago

https://github.com/abhishek-ram/pyas2-lib/pull/52

robincsamuel commented 2 years ago

@abhishek-ram will you be able to make a release soon with these changes?

abhishek-ram commented 2 years ago

Done 1.4.1