search

abhishek-ram / pyas2-lib

AS2 Library for building and parsing Messages and MDNs
GNU General Public License v3.0
43 stars 28 forks source link

error oscrypto/_openssl/asymmetric.py in load_pkcs12 loading crt file #53

Open osvaldo35 opened 2 years ago

osvaldo35 commented 2 years ago

there is a bug in how the asymmetric loads the certificate, it s expecting a file not a bytes stream, 

self.send_to_apple(tstr, company_id, 'response_867')

File "/home/osvaldo/odoos/odoo13/extra-addons_tmp/cliente_oneclick/clientes/apple_EDI_AS2_reports/models/models.py", line 62, in send_to_apple my_org = Organization( File "", line 11, in init File "/usr/local/lib/python3.8/dist-packages/pyas2lib/as2.py", line 96, in __post_init__ self.sign_key = self.load_key(self.sign_key, self.sign_key_pass) File "/usr/local/lib/python3.8/dist-packages/pyas2lib/as2.py", line 107, in loadkey key, cert, = asymmetric.load_pkcs12(key_str, key_pass) File "/usr/local/lib/python3.8/dist-packages/oscrypto/_openssl/asymmetric.py", line 811, in load_pkcs12 with open(source, 'rb') as f: FileNotFoundError: [Errno 2] the file or drectory does nott exist: '-----BEGIN OPENSSH PRIVATE KEY-----\nb3BlbnNzaC1rZXktdjEAAAAACmFlczI1Ni1jdHIAAAAGYm

chadgates commented 8 months ago

Hello @osvaldo35

It seems that you passed a string object which it seems in oscrypto will be used to open files. When using bytes, it will use bytes... (at least that is what I can see from the source code).

Can this ticket be closed ?