abhishek-ram / pyas2-lib

AS2 Library for building and parsing Messages and MDNs
GNU General Public License v3.0
43 stars 28 forks source link

Async callback functions, partnership function, rsaes_oaep for KeyEncryptionAlgorithm #65

Closed chadgates closed 5 months ago

chadgates commented 6 months ago

Adding following features:

I am wondering if this should be last version to support python 3.7 and with next version we should upgrade python 3.8 - python 3.12? This also means, we have to upgrade some packages as well. Had to upgrade pytest for better async testing support.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 98.63014% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.78%. Comparing base (b9dc0a2) to head (cbf0659). Report is 1 commits behind head on master.

Files Patch % Lines
pyas2lib/as2.py 97.72% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #65 +/- ## ========================================== + Coverage 96.45% 96.78% +0.32% ========================================== Files 6 6 Lines 734 778 +44 Branches 131 147 +16 ========================================== + Hits 708 753 +45 + Misses 14 13 -1 Partials 12 12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

abhishek-ram commented 6 months ago

can we split the changes into 3 PRs?

chadgates commented 6 months ago

Would be earliest in May. And was trying to avoid merge conflicts. Which order/separation would you like to get them?

chadgates commented 5 months ago

Closed to split into separate PR's