search

abhishek-vinjamoori / SubtitleExtractor

This repository is aimed at downloading subtitles from popular Internet Services.
28 stars 13 forks source link

Dead code removal #10

Open manveerxyz opened 7 years ago

manveerxyz commented 7 years ago

Multiple instances across many files where code is never called upon or has no purpose. Example:

firefox_profile = webdriver.FirefoxProfile() firefox_profile.set_preference('permissions.default.stylesheet', 2) firefox_profile.set_preference('permissions.default.image', 2) firefox_profile.set_preference('dom.ipc.plugins.enabled.libflashplayer.so', 'false')

^ This block of code is present in some files, however firefox_profile is never used because a chrome driver is initiated instead 'driver = webdriver.Chrome()'

There are also some unnecessary pass statements at the end of functions which have no purpose.

Multiple blocks of code have been commented off in numerous locations (possibly done for testing purposes when code was being written) in the repository, these should also be removed to keep the code clean.

manveerxyz commented 7 years ago

Once #18 is merged, this issue should be closed