search

abhishek-vinjamoori / SubtitleExtractor

This repository is aimed at downloading subtitles from popular Internet Services.
28 stars 13 forks source link

Common functions re-factoring #7

Open ghost opened 8 years ago

ghost commented 8 years ago

createSoupObject is common to bbc, comedycentral, crackle, crunchyroll, fox, hulu, netflix, youtube and can be refactored. Despite it being in common already?

deleteUnnecessaryfiles is common to all, but already appears in common.

downloadXMLTranscript is common to bbc, crackle, and youtube

convertXMLToSrt is common to bbc, crunchyroll, and youtube

downloadDfxpTranscript is common to amazon, comedycentral and netflix

getContentID1 and getContentID2 are common to comedycentral and fox, and hulu, but hulu has a different version.

getShowJson, getShowDetails, getSubtitleUrl, and processShowName are common to comedycentral and fox. comedycentral and fox seem to share a lot of code.

BBC and crackle share the same getTitle code.

abhishek-vinjamoori commented 7 years ago

downloadXMLTranscript for "BBC,Crackle" and Youtube are different. Would like to see how you merge them in the code.

getContentID1 and getContentID2 of Hulu might be completely different. You can ignore that.

Regarding getShowJson, getShowDetails check if the functions are really being used. Otherwise you can simply ignore them.