search

abhishek-vinjamoori / SubtitleExtractor

This repository is aimed at downloading subtitles from popular Internet Services.
28 stars 13 forks source link

Refactors common code #8

Closed ghost closed 7 years ago

ghost commented 7 years ago

createSoupObject, deleteUnnecessaryfiles, downloadXMLTranscript, getTitle, downloadDfxpTranscript, and convertXMLToSrt are refactored into common.py

abhishek-vinjamoori commented 7 years ago

Look at the common named functions and see if the code is exactly the same or you require some extra parameters for these SIMILAR functions and then add them in common.py so that you can merge them.

ghost commented 7 years ago

Yes, I've done that. A few require parameters, such as downloadXMLTranscript, which one has different encoding needs and another has a different URL, so I added in two extra input variables so that those can be done.

abhishek-vinjamoori commented 7 years ago

This requires more work. Please verify ALL the functions from ALL modules once again.